  Rank: Advanced Member Groups: Registered
Joined: 23/07/2013(UTC) Posts: 1,128  Was thanked: 509 time(s) in 339 post(s)
|
I have been trying to make this code work for two days. Actually it is a C code which I am trying to implicate to SMath. C code is also included and runs perfectly. In SMath, code works to a point actually. When I debug it I can see it can assign numbers, backtrack if there is no option. So SMath code also seems legit but eventually the algorithm just stop working. No error no significant reason. With different puzzles, code terminated at different places at middle of calculation. I couldn't figure out what is wrong. Is it a bug or my coding is insufficient? Any help should be appreciated. Regards.  sudoku.sm (27kb) downloaded 39 time(s). sudoku.7z (39kb) downloaded 19 time(s).
|
|
|
|
|
|
Rank: Advanced Member Groups: Registered
Joined: 23/03/2016(UTC) Posts: 277  Was thanked: 91 time(s) in 57 post(s)
|
I posted something very inaccurate before and have since deleted it. However, in my testing, it seems that it's not dependent on the number of iterations. The function seems to stop when rw,cl get to around 2,4 or 2,5. This is independent of the number of function calls to fillSudoku. |
|
|
|
|
|
|
Rank: Advanced Member Groups: Registered
Joined: 23/03/2016(UTC) Posts: 277 Was thanked: 91 time(s) in 57 post(s)
|
Originally Posted by: alyles  I posted something very inaccurate before and have since deleted it. However, in my testing, it seems that it's not dependent on the number of iterations. The function seems to stop when rw,cl get to around 2,4 or 2,5. This is independent of the number of function calls to fillSudoku. This looks to correlate to a depth of ~21 or 22 levels of recursion no matter the starting puzzle. |
|
|
|
|
|
|
 Rank: Guest
Groups: Registered
Joined: 04/07/2015(UTC) Posts: 6,866  Was thanked: 981 time(s) in 809 post(s)
|
Originally Posted by: overlord With different puzzles, code terminated at different places at middle of calculation.
I couldn't figure out what is wrong. Is it a bug or my coding is insufficient? I never heard of Sudoku. As it looks, you first scan for coincidence. Can it relate to some truth table ? Then else game ... ! 
|
|
|
|
|
|
Rank: Guest
Groups: Registered
Joined: 04/07/2015(UTC) Posts: 6,866 Was thanked: 981 time(s) in 809 post(s)
|
... your original creates "critical error", that can be repaired in the first module.
|
|
|
|
|
|
Rank: Guest
Groups: Registered
Joined: 04/07/2015(UTC) Posts: 6,866 Was thanked: 981 time(s) in 809 post(s)
|
Originally Posted by: Jean Giraud ... your original creates "critical error", that can be repaired in the first module. Sudoku First Module.sm (18kb) downloaded 12 time(s).
|
|
|
|
|
|
Rank: Guest
Groups: Registered
Joined: 04/07/2015(UTC) Posts: 6,866 Was thanked: 981 time(s) in 809 post(s)
|
... make sure you completely understand the Bolean from the code you imitate. As corrected, red. Red may mean not winning ? sudoku Freak.sm (24kb) downloaded 15 time(s).
|
|
|
|
|
|
Rank: Advanced Member Groups: Registered
Joined: 23/03/2016(UTC) Posts: 277 Was thanked: 91 time(s) in 57 post(s)
|
Originally Posted by: alyles Originally Posted by: alyles I posted something very inaccurate before and have since deleted it. However, in my testing, it seems that it's not dependent on the number of iterations. The function seems to stop when rw,cl get to around 2,4 or 2,5. This is independent of the number of function calls to fillSudoku. This looks to correlate to a depth of ~21 or 22 levels of recursion no matter the starting puzzle. To better illustrate what I think is happening I've created the following worksheet. The first function definition is just a simple function that calls itself recursively until its 200th call at which point it exits. However, when run it experiences the same error as we see in the sudoku.sm. I rewrote the function using a try/on error and we see we only get to 50 iterations before it fails.  recursion.sm (5kb) downloaded 13 time(s). |
|
|
|
|
|
|
Rank: Advanced Member Groups: Registered
Joined: 23/07/2013(UTC) Posts: 1,128 Was thanked: 509 time(s) in 339 post(s)
|
Originally Posted by: alyles This looks to correlate to a depth of ~21 or 22 levels of recursion no matter the starting puzzle. What I understood considering your last messages, you think there is nothing significant wrong with the code itself. Problem is SMath handling of recursions. So, it comes forward that is why I wouldn't be able to make an SMath Sudoku Solver with recursion. Thank you Alyles. Edited by user 09 July 2021 01:22:14(UTC)
| Reason: Not specified
|
|
|
|
|
|
Rank: Guest
Groups: Registered
Joined: 04/07/2015(UTC) Posts: 6,866 Was thanked: 981 time(s) in 809 post(s)
|
I think it's possible to fill the '0' positions of the 9x9 Sudoku with random not common to the existing filled position. Filling one col at time, collect ... 
|
|
|
|
|
|
 Rank: Advanced Member Groups: Registered, Advanced Member Joined: 13/01/2012(UTC) Posts: 2,650   Location: Italy Was thanked: 1338 time(s) in 878 post(s)
|
Originally Posted by: overlord Originally Posted by: alyles This looks to correlate to a depth of ~21 or 22 levels of recursion no matter the starting puzzle. What I understood considering your last messages, you think there is nothing significant wrong with the code itself. Problem is SMath handling of recursions. So, it comes forward that I wouldn't be able to make an SMath Sudoku Solver. Thank you Alyles. I remember this limitation was introduced some time ago to avoid unintentional hard crashes on wrong formed algorithms; considering that any recursive algorithm can be made iterative, you probably have to design it in another way or find a different code  |
If you like my plugins consider to support SMath Studio buying a plan; to offer me a coffee: paypal.me/dcprojects |
 1 user thanked Davide Carpi for this useful post.
|
|
|
|
Rank: Advanced Member Groups: Registered
Joined: 23/03/2016(UTC) Posts: 277 Was thanked: 91 time(s) in 57 post(s)
|
As Davide said, you don't have to do it recursively.  It may be slow, but it works. Might be able to optimize for better performance.  sudoku_lyles2.sm (29kb) downloaded 21 time(s). |
|
1 user thanked alyles for this useful post.
|
|
|
|
Rank: Advanced Member Groups: Registered
Joined: 23/03/2016(UTC) Posts: 277 Was thanked: 91 time(s) in 57 post(s)
|
Well it works for the first two puzzles at least. Having issues with the third. Haven't tried the fourth.... It's a start |
|
|
|
|
|
|
 Rank: Advanced Member Groups: Registered
Joined: 05/06/2014(UTC) Posts: 348  Location: Colombo Was thanked: 125 time(s) in 82 post(s)
|
Originally Posted by: alyles
Well it works for the first two puzzles at least. Having issues with the third. Haven't tried the fourth....
It works for the fourth, but fails for the third puzzle. |
Look within!... The secret is inside you.
Best Regards
Eng. NDTM Amarasekera - Sri Lanka |
|
|
|
|
|
Rank: Advanced Member Groups: Registered
Joined: 23/07/2013(UTC) Posts: 1,128 Was thanked: 509 time(s) in 339 post(s)
|
Originally Posted by: Davide Carpi I remember this limitation was introduced some time ago to avoid unintentional hard crashes on wrong formed algorithms; considering that any recursive algorithm can be made iterative, you probably have to design it in another way or find a different code Wow, I didn't know there is a purposed limitation for recursion. For those who knows what they are doing, I think that limit can be removed by adding an extra code at the beginning like (recurselimit:=0), or re-adding the limit (recurselimit:=1). Yeah it can be made iterative, alyles already did one as far as I can see. I just wanted you guys to check if I did something wrong about my algorithm. I just love recursing, I always feel like it is magical to me. Thank you all guys, regards
|
|
|
|
|
|
Rank: Advanced Member Groups: Registered
Joined: 23/07/2013(UTC) Posts: 1,128 Was thanked: 509 time(s) in 339 post(s)
|
Originally Posted by: ndtma Originally Posted by: alyles
Well it works for the first two puzzles at least. Having issues with the third. Haven't tried the fourth....
It works for the fourth, but fails for the third puzzle. Don't bother about it. I found these sudoku's on internet without checking them. I checked that puzzle with C code right now and it has no solution. Regards
|
|
|
|
|
|
Rank: Guest
Groups: Registered
Joined: 04/07/2015(UTC) Posts: 6,866 Was thanked: 981 time(s) in 809 post(s)
|
Confirmed: puzzle 3 fails "Requested matrix does not exist" [q=> 1..99]
|
|
|
|
|
|
Rank: Advanced Member Groups: Registered
Joined: 28/08/2014(UTC) Posts: 1,357  Was thanked: 817 time(s) in 517 post(s)
|
Originally Posted by: overlord
Wow, I didn't know there is a purposed limitation for recursion. For those who knows what they are doing, I think that limit can be removed by adding an extra code at the beginning like (recurselimit:=0), or re-adding the limit (recurselimit:=1).
Hi. It exists in other languages. For instance, can see it at https://reference.wolfram.com/language/ref/$RecursionLimit.html Best regards. Alvaro.
|
1 user thanked Razonar for this useful post.
|
|
|
|
Rank: Guest
Groups: Registered
Joined: 04/07/2015(UTC) Posts: 6,866 Was thanked: 981 time(s) in 809 post(s)
|
Originally Posted by: overlord Don't bother about it. I found these sudoku's on internet without checking them.
I checked that puzzle with C code right now and it has no solution. You mean puzzle 3 has no solution ? Solution is => give to champions. Attached utilities may be useful otherwise. Mathemtica 4.0 "recursion limit" is pure jargon. In some program, if/otherwise does not work [if/else = YES]. Is there a catch wrt puzzle 3 ... Watson ? Utilities Matrix Count in Soduku.sm (23kb) downloaded 10 time(s).
|
|
|
|
|
|
Rank: Advanced Member Groups: Registered
Joined: 28/08/2014(UTC) Posts: 1,357 Was thanked: 817 time(s) in 517 post(s)
|
Hi. Here, the mathcad 11 version for the recursive method. Notice that mathcad don't pass values by reference, only by value, so the matrix can't be modified inside the fucntion, only 'outside'. Also, mathcad have the return function as keyword but isn't used. SudokuRec.zip (25kb) downloaded 12 time(s). SudokuRec.pdf (286kb) downloaded 15 time(s).This other is te recurrent version in SMath: don't works. SudokuRec.sm (46kb) downloaded 13 time(s).This other is a rewrite of the alyles version. SudokuBruteForce_lyles.sm (44kb) downloaded 26 time(s).Best regards. Alvaro. Edited by user 03 September 2019 05:18:41(UTC)
| Reason: Not specified
|
1 user thanked Razonar for this useful post.
|
|
|
|
Forum Jump
You cannot post new topics in this forum.
You cannot reply to topics in this forum.
You cannot delete your posts in this forum.
You cannot edit your posts in this forum.
You cannot create polls in this forum.
You cannot vote in polls in this forum.
